Skip to content

chgres_cube: Implement WMO grib2 template 1 (rotated lat-lon) read capability#902

Merged
GeorgeGayno-NOAA merged 4 commits into
ufs-community:developfrom
LarissaReames:feature/chgres_rrfs_RLL
Feb 27, 2024
Merged

chgres_cube: Implement WMO grib2 template 1 (rotated lat-lon) read capability#902
GeorgeGayno-NOAA merged 4 commits into
ufs-community:developfrom
LarissaReames:feature/chgres_rrfs_RLL

Conversation

@LarissaReames
Copy link
Copy Markdown
Contributor

@LarissaReames LarissaReames commented Feb 23, 2024 •
edited by GeorgeGayno-NOAA
Loading

DESCRIPTION OF CHANGES:

RRFS Fire needs to be able to initialize from the rotated lat-lon grib2 RRFS files which are on the WMO grib2 template 1. This implements the capacity to read data on that template. Also added 'RRFS' as a supported external_model namelist input. though it's not required to support this grid template. Full versions of those RRFS file, however, are still not supported as they are too large (>2GB). That will be addressed when #850 is fixed.

TESTS CONDUCTED:

Intel builds on Jet and Hera. Gnu builds on Hera. Unit tests pass on Hera. Consistency tests pass on Hera. Need support for: Orion, Hercules, WCOSS2 intel builds. Debug build on WCOSS2.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 804ea27.
  • Compile branch on Hera using GNU. Done using 804ea27.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Dogwood using 804ea27.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 804ea27.
  • Run relevant consistency tests locally on all Tier 1 machine. Done using 804ea27. All tests failed on Jet. However, the baseline was created on xjet. Those nodes have been migrated to a new operating system, on which UFS_UTILS has not been tested. Running on vjet nodes resulted in floating point differences.

DEPENDENCIES:

N/A

DOCUMENTATION:

Updated documentation to note that 'RRFS' is now a supported external_model option.

ISSUE:

Resolves #901

CONTRIBUTORS (optional):

@GeorgeGayno-NOAA contributed the grib1 grid definition information

@LarissaReames LarissaReames self-assigned this Feb 23, 2024
@GeorgeGayno-NOAA
Copy link
Copy Markdown
Collaborator

GeorgeGayno-NOAA commented Feb 23, 2024

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

@LarissaReames
Copy link
Copy Markdown
Contributor Author

LarissaReames commented Feb 23, 2024 •
edited
Loading

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

I'd thought about that, but thought maybe we'd wait until we can support the full RRFS grib2 files with the new g2 library. I was only able to confirm that the current updates worked with a sub-CONUS file from Ben interpolated to an even smaller sub-CONUS output grid.

GeorgeGayno-NOAA
GeorgeGayno-NOAA reviewed Feb 26, 2024
View reviewed changes
Comment thread sorc/chgres_cube.fd/atm_input_data.F90 Outdated
GeorgeGayno-NOAA
GeorgeGayno-NOAA reviewed Feb 26, 2024
View reviewed changes
Comment thread sorc/chgres_cube.fd/model_grid.F90
@GeorgeGayno-NOAA
Copy link
Copy Markdown
Collaborator

GeorgeGayno-NOAA commented Feb 26, 2024

Should we add a new consistency test? This test uses the local NCEP template for rotated latl/on:

The new test could be the same except for the input data (which would use the WMO template).

I'd thought about that, but thought maybe we'd wait until we can support the full RRFS grib2 files with the new g2 library. I was only able to confirm that the current updates worked with a sub-CONUS file from Ben interpolated to an even smaller sub-CONUS output grid.

Did you test the coldstart files in the model?

I will help with testing on the machines you don't have access to.

@GeorgeGayno-NOAA
Copy link
Copy Markdown
Collaborator

GeorgeGayno-NOAA commented Feb 27, 2024

@LarissaReames-NOAA Can I merge this?

@LarissaReames
Copy link
Copy Markdown
Contributor Author

LarissaReames commented Feb 27, 2024

@GeorgeGayno-NOAA sounds good to me!

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 1dac855 into ufs-community:develop Feb 27, 2024
@MichaelLueken MichaelLueken mentioned this pull request May 31, 2024
Merged
40 tasks
MichaelLueken pushed a commit to NOAA-EPIC/UFS_UTILS that referenced this pull request Feb 13, 2025
@LarissaReames @MichaelLueken
chgres_cube: Implement WMO grib2 template 1 (rotated lat-lon) read ca…
0efd4ee 
…pability (ufs-community#902)

Add ability to read GRIB2 data that uses the WMO-standard rotated lat-lon grid
template (GRIB2 grid template 1). Update 'readthedocs'.

Fixes ufs-community#901.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeGayno-NOAA GeorgeGayno-NOAA GeorgeGayno-NOAA approved these changes

+1 more reviewer

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LarissaReames LarissaReames

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add chgres_cube capability to read data on WMO rotated lat-lon grid (template 1)

3 participants

@LarissaReames @GeorgeGayno-NOAA @JeffBeck-NOAA